Add sumbit method to enable the programmatic submission #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refs #500. Thanks! |
sbusch
added a commit
to sbusch/react-jsonschema-form
that referenced
this pull request
Oct 26, 2018
…TML form ..., navigating away from current page at least in Firefox. Reason: dispatched event was not cancelable, so preventDefault in onSubmit couldn't cancel it. Links: * <https://stackoverflow.com/a/40916998> * <https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelable>
4 tasks
glasserc
pushed a commit
that referenced
this pull request
Oct 26, 2018
…1066) ..., navigating away from current page at least in Firefox. Reason: dispatched event was not cancelable, so preventDefault in onSubmit couldn't cancel it. Links: * <https://stackoverflow.com/a/40916998> * <https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelable>
althalus86
added a commit
to althalus86/react-jsonschema-form
that referenced
this pull request
Nov 3, 2018
…ng the HTML form (rjsf-team#1066)" This reverts commit 6cb26d1.
epicfaace
pushed a commit
that referenced
this pull request
May 22, 2019
* react-dom is external peerDependency, just like react. fixes version conflicts, e.g. I got an error Uncaught TypeError: this.updater.enqueueCallback is not a function when using setState callback because I use React 16.x and react-jsonschema-form bundled react-dom 15.x See facebook/react#10320 (comment) * Fix for new submit() method (PR #1058) also submitting the HTML form ..., navigating away from current page at least in Firefox. Reason: dispatched event was not cancelable, so preventDefault in onSubmit couldn't cancel it. Links: * <https://stackoverflow.com/a/40916998> * <https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelable> * Synchronous call to onSubmit() from props Due to the use of setImmediate() hack in setState utility function (utils.js), onSubmit() handler from props is called asynchronously. This leads to massive problems for operations requiring "trusted events", like window.open() or programmatically submitting forms with target "_blank" (which we needed) Because onSubmit() should not need the performance-related setImmiate() hack, I replaced call to setState utility function with proper this.setState() from React. * fix failing FileWidget tests by changing to proper use of setState() without setImmediate() hacks (see #1197) * fix input type, fix test name * Test with newer node versions * Add node 12
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
In some user case, the form should be submitted by the javascript program programmatically, for example, the submit button in the UI design is separated from the form.
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style